Ask here about the “Classical Factorization” Codebook topic from the “Shor’s Algorithm” module.
The text and code in this section says “nontrivial square root of m” and “nontrivial square root modulo m” interchangeably to mean the same thing. I would like it if all such terminology was standardized to “nontrivial square root modulo m”.
Reason being that they are frequently referred to more precisely as “nontrivial square roots of unity modulo m”, and they aren’t square roots of m in the usual sense that their square is m; rather, their square is 1.
Thanks for this feedback @jhanschoo ! I agree your suggestion can help avoid confusion.